Skip to content

OZ Audit fix medium severity issues (on Bedrock)#2749

Merged
maurelian merged 6 commits intom/low-oz-fixesfrom
m/medium-oz-fixes
Jun 14, 2022
Merged

OZ Audit fix medium severity issues (on Bedrock)#2749
maurelian merged 6 commits intom/low-oz-fixesfrom
m/medium-oz-fixes

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

This PR fixes the Low and Informational severity issues issues in the OpenZeppelin audit (which is not yet public). Each commit in this PR clearly references the finding that it addresses.

In order to review, I suggest comparing between the audit report (see the "Open Zeppelin Audit Resolution" doc in Notion), and the commit which mentions it.

This PR is being applied to the branch in #2748, which builds on the state of the develop branch as it was immediately after merging the bedrock branch.

maurelian added 6 commits June 9, 2022 20:52
fixup! contracts: Fix OZ-N-03 Complex ERC165 implementation
This commit also expands on the natspec comments to clarify how the additional
data may be used.

fixup! contracts: Fix OZ-M-05 rename _data to _extraData
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 10, 2022

⚠️ No Changeset found

Latest commit: c73da94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 10, 2022

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 10, 2022
@mergify mergify bot removed the conflict label Jun 10, 2022
@maurelian
Copy link
Copy Markdown
Contributor Author

There is no changeset here, because contracts-bedrock was not a package at this point in history.

@maurelian maurelian changed the title OZ Audit fix medium severity issues OZ Audit fix medium severity issues (on Bedrock) Jun 13, 2022
@maurelian
Copy link
Copy Markdown
Contributor Author

Merging this.
Internal review can be done on #2765

@maurelian maurelian merged commit afdf38d into m/low-oz-fixes Jun 14, 2022
@maurelian maurelian deleted the m/medium-oz-fixes branch June 14, 2022 13:54
theochap pushed a commit that referenced this pull request Dec 10, 2025
Move the `kona-comp` crate from the `crates/protocol/` directory to a
new `crates/batcher/` directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant